Skip to content

feat: support pre-variadic parameters in editor hints - #162

Open
davhdavh wants to merge 2 commits into
mainfrom
feat/pre-variadic-parameters
Open

davhdavh wants to merge 2 commits into
mainfrom
feat/pre-variadic-parameters

Conversation

@davhdavh

@davhdavh davhdavh commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Keep signature-help highlighting on the variadic tail once the typed prefix has been entered, for functions, instance/static methods, and constructors.
  • Bundle both formatToUser overloads introduced by Catglobe/Catglobe#1457 for offline editor support.
  • Add 30 regression cases covering typed-prefix validation, empty and mixed-type tails, legacy variadic-only calls, non-variadic hints, and both formatToUser overloads.
  • Override StreamJsonRpc's transitive MessagePack dependency with patched version 2.5.303 to resolve the CI restore failure (GHSA-qhrr-8q5h-9q3h), keeping NuGet auditing enabled.

Semantic validation already supported typed prefixes; these tests lock in that behavior.

Closes #161

Validation

  • dotnet test --results-directory <temp-results-directory> --logger "trx;LogFileName=test-results.trx" -p:CollectCoverage=true — all 455 solution tests pass (374 LSP and 81 deployment), and both coverage reports are generated with NuGet auditing enabled. Existing unrelated demo dependency and analyzer warnings remain.
  • dotnet build Catglobe.CgScript.EditorSupport.Lsp/Catglobe.CgScript.EditorSupport.Lsp.csproj --verbosity minimal — .NET 8 and .NET 10 builds pass with zero warnings/errors.
  • git diff --check — clean.

This PR was prepared by an AI agent, not a human.

@github-actions

Copy link
Copy Markdown

Summary

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Catglobe.CgScript.Common 27.9% 22.7%
Catglobe.CgScript.Deployment 58.8% 31.4%
Catglobe.CgScript.EditorSupport.Lsp 40.6% 40.6%
Catglobe.CgScript.EditorSupport.Parsing 68.8% 66.1%
Catglobe.CgScript.EditorSupport.SourceGenerator 69.7% 29.3%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support pre-variadic parameters

1 participant